Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added github oidc token as a header #471

Merged
merged 2 commits into from
Oct 16, 2024
Merged

feat: added github oidc token as a header #471

merged 2 commits into from
Oct 16, 2024

Conversation

eloymg
Copy link
Contributor

@eloymg eloymg commented Oct 16, 2024 •
edited
Loading

added github oidc token as a header. This allow us to remove IAP proxy from the auth process beacouse we validate the github OIDC token directly.

@eloymg eloymg requested a review from a team as a code owner October 16, 2024 09:12
@iainlane
Copy link
Member

iainlane commented Oct 16, 2024 •
edited
Loading

Thanks! I'd expand the commit message just slightly to say that this allows us to remove IAP from the auth process by having a separate proxy.

@eloymg eloymg added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 6426ecd Oct 16, 2024
14 checks passed
@eloymg eloymg deleted the add-github-oidc-token-as-header branch October 16, 2024 11:58
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainlane iainlane iainlane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eloymg @iainlane